Flutter customer tests override operator == with a dynamic parameter.

[srawlins]

See failures here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791703831221213185/+/u/Customer_testing/customer_testing/test_stdout

We have to fix all of these before issuing a warning about it.

• flutter_portal - == override parameters are non-nullable fzyzcjy/flutter_portal#98
  • bump flutter/tests - Bump flutter_portal.test to bring in analysis fix flutter/tests#211
• flutter/cocoon - == override parameters are non-nullable flutter/cocoon#2400
  • bump flutter/tests - Bump flutter_cocoon.test to bring analysis fix flutter/tests#210
• flutter_reactive_ble - Make operator == override parameters non-nullable PhilipsHue/flutter_reactive_ble#677
  • bump flutter/tests - Bump flutter_reactive_ble.test to bring analysis fix flutter/tests#219

[navaronbracke]

@srawlins If I'm not mistaken you should be using other is SomeType && <other checks here> instead of as?

Yes, you will get a warning from the unrelated_type_equality_checks lint but it fails at runtime with a type cast error.

[srawlins]

I'm not sure what you're referring to. One of the PRs? Could you comment on the PR?

[navaronbracke]

@srawlins I commented on PhilipsHue/flutter_reactive_ble#677 to clarify.

Not sure about the cast in the flutter_cocoon PR, but per flutter/cocoon#2400 (comment) I think its fine?