Fix renaming super formal parameters in long subclass chains.

Bug: #61194

Change-Id: Icb3b8e5044e13e046122490e1dfceb5dc944eafe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/442170
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Author: fshcheglov

pkg/analysis_server/lib/src/services/refactoring/legacy/rename_parameter.dart

@@ -114,19 +114,16 @@ class RenameParameterRefactoringImpl extends RenameRefactoringImpl {
       }
       var references = await searchEngine.searchReferences(element);
 
-      // Remove references that don't have to have the same name.
+      // Named super formals are already in [elements].
+      // Positional super formals are not tied by name so shouldn't be renamed.
+      references.removeWhere(
+        (match) => match.element is analyzer.SuperFormalParameterElement,
+      );
 
       // Implicit references to optional positional parameters.
       if (element.isOptionalPositional) {
         references.removeWhere((match) => match.sourceRange.length == 0);
       }
-      // References to positional parameters from super-formal.
-      if (element.isPositional) {
-        references.removeWhere(
-          (match) => match.element is analyzer.SuperFormalParameterElement,
-        );
-      }
-
       processor.addReferenceEdits(references);
     }
   }
@@ -136,6 +133,17 @@ class RenameParameterRefactoringImpl extends RenameRefactoringImpl {
     var element = this.element;
     if (element.isNamed) {
       elements = await getHierarchyNamedParameters(searchEngine, element);
+
+      // Iteratively collect superFormalParameter(s) of subclasses.
+      for (var i = 0; i < elements.length; i++) {
+        var element = elements[i];
+        var references = await searchEngine.searchReferences(element);
+        elements.addAll(
+          references
+              .map((match) => match.element)
+              .whereType<analyzer.SuperFormalParameterElement>(),
+        );
+      }
     } else if (element.isPositional) {
       elements = await getHierarchyPositionalParameters(searchEngine, element);
     }

pkg/analysis_server/test/services/refactoring/legacy/rename_parameter_test.dart

@@ -202,6 +202,12 @@ class A {
 class B extends A {
   B({required super.test});
 }
+class C extends B {
+  C({required super.test});
+}
+class D extends C {
+  D({required super.test});
+}
 ''');
     // configure refactoring
     createRenameRefactoringAtString('test}); // 0');
@@ -216,6 +222,12 @@ class A {
 class B extends A {
   B({required super.newName});
 }
+class C extends B {
+  C({required super.newName});
+}
+class D extends C {
+  D({required super.newName});
+}
 ''');
   }