Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: downloads sparkline hover is hidden under mouse #8301

Open
eseidel opened this issue Nov 18, 2024 · 6 comments
Open

fix: downloads sparkline hover is hidden under mouse #8301

eseidel opened this issue Nov 18, 2024 · 6 comments
Labels
Accessibility Issues with the accessibility of the site. Type: bug

Comments

@eseidel
Copy link

eseidel commented Nov 18, 2024

When you hover the sparkline the number tracks under your cursor (rather than the line), so you can't move the mouse off from over the number to see it.

image

Screenshots don't show the mouse cursor, so it's hard to show you the bug.

FYI @szakarias

@eseidel
Copy link
Author

eseidel commented Nov 18, 2024

Ah! When I capture with the mouse pointer enabled I see the potential bug:
image

I have mouse cursor zoom enabled (which it appears the screenshot tool does not respect, and the pub.dev code does not account for):

image

@eseidel
Copy link
Author

eseidel commented Nov 18, 2024

Here is how it looks taken from my phone camera looking at my screen:
image

@sigurdm sigurdm added Accessibility Issues with the accessibility of the site. Type: bug labels Nov 19, 2024
@sigurdm
Copy link
Contributor

sigurdm commented Nov 19, 2024

According to https://stackoverflow.com/questions/1889487/get-size-of-mouse-cursor-in-javascript there is no way of querying for the cursor size from a web-context.

We could maybe change the cursor to a size of our liking when hovering the sparkline - but that seems unfriendly to people who chose a larger cursor.

Perhaps we should put the tooltip in a fixed position?

@eseidel
Copy link
Author

eseidel commented Nov 19, 2024

I'd probably just put it in a fixed position. NPM for example puts it to the side:
image

@eseidel
Copy link
Author

eseidel commented Nov 19, 2024

Github puts it above the cursor:
image

@eseidel
Copy link
Author

eseidel commented Nov 19, 2024

Anyway, I'm not a UI designer, I defer to folks with much more design ability than myself. Just wanted to report that at least in my setup I couldn't read the numbers. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues with the accessibility of the site. Type: bug
Projects
None yet
Development

No branches or pull requests

2 participants