Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation issue for the generalized type alias feature #115

Closed
eernstg opened this issue Nov 29, 2018 · 5 comments
Closed

Implementation issue for the generalized type alias feature #115

eernstg opened this issue Nov 29, 2018 · 5 comments
Labels
implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue

Comments

@eernstg
Copy link
Member

eernstg commented Nov 29, 2018

[Edit Feb 2021: The implementation issue needs to be in the SDK repo, so we will use https://github.com/dart-lang/sdk/issues/44951 as the implementation issue for non-function type aliases. Deleted the check boxes below to avoid duplication and confusion.]

This issue is for tracking implementation of the generalized type alias feature:

Request issue: #66
Feature issue: #65
Main SDK tracking issue: dart-lang/sdk#44951

Feature specification:
https://github.com/dart-lang/language/blob/master/accepted/future-releases/generalized-typedef-2018/feature-specification.md

Implementation plan:
https://github.com/dart-lang/language/blob/master/accepted/future-releases/generalized-typedef-2018/implementation-plan.md

[List of tasks and check boxes deleted: See https://github.com/dart-lang/sdk/issues/44951]

@mit-mit mit-mit added the implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue label Nov 30, 2018
@srawlins
Copy link
Member

I think this needs another step, "Implementation in DartDoc".

@leafpetersen
Copy link
Member

Added some missing things.

@munificent munificent changed the title Implementation issue for the generalized type alias feature Q1'19 Implementation issue for the generalized type alias feature Nov 20, 2020
@srawlins
Copy link
Member

I think there are some important missing items from the check list. Considering grok (now Kythe), Cider, and Angular are in Phase 0, these should probably be Phase 0:

  • analysis_server core features (Go To Definition, Find References, Sort Declarations)
  • analysis_server auto-complete (name, constructors)
  • analyzer: include generalized type alias test cases in existing diagnostic tests (invalid assignment, type alias application in places like catch, extends, constructor redirection, unnecessary cast with as, unused type aliases, invalid access to a @protected constructor, member, etc)
  • linter: consider existing lints; add test cases and application to generalized type alias

@eernstg
Copy link
Member Author

eernstg commented Dec 22, 2020

Thanks, added those items to the list.

@eernstg
Copy link
Member Author

eernstg commented Feb 12, 2021

Closing this issue, the new implementation issue for this feature is dart-lang/sdk#44951.

@eernstg eernstg closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation Track the implementation of a specific feature OBSOLETE: Please use SDK issue
Projects
None yet
Development

No branches or pull requests

4 participants