diff --git a/pkgs/firehose/CHANGELOG.md b/pkgs/firehose/CHANGELOG.md index 151e54a1..0ee7b55d 100644 --- a/pkgs/firehose/CHANGELOG.md +++ b/pkgs/firehose/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.12.1-wip + +- Make the PR health output less verbose by collapsing warnings by default. + ## 0.12.0 - Make the location of the health.yaml workflow configurable. diff --git a/pkgs/firehose/lib/src/health/health.dart b/pkgs/firehose/lib/src/health/health.dart index 7506ae37..17e51b1c 100644 --- a/pkgs/firehose/lib/src/health/health.dart +++ b/pkgs/firehose/lib/src/health/health.dart @@ -17,7 +17,7 @@ import 'changelog.dart'; import 'coverage.dart'; import 'license.dart'; -const apiToolHash = '7422ff6481101765899ae37495ce667acb400589'; +const apiToolHash = '4377249ec08f0fa508298077eae236f24f315e19'; enum Check { license('License Headers', 'license'), @@ -506,17 +506,20 @@ This check for [test coverage](https://github.com/dart-lang/ecosystem/wiki/Test- final String markdownSummary; if (result.markdown != null) { var markdown = result.markdown; - var isWorseThanInfo = result.severity.index >= Severity.warning.index; + var expand = switch (result.severity) { + Severity.success || Severity.info || Severity.warning => false, + Severity.error => true, + }; markdownSummary = ''' - + ${check.tag} ${result.severity.emoji} $markdown -${isWorseThanInfo ? 'This check can be disabled by tagging the PR with `skip-${result.check.displayName}-check`.' : ''} +This check can be disabled by tagging the PR with `skip-${result.check.displayName}-check`. '''; diff --git a/pkgs/firehose/pubspec.yaml b/pkgs/firehose/pubspec.yaml index dbe943c8..6c4f0081 100644 --- a/pkgs/firehose/pubspec.yaml +++ b/pkgs/firehose/pubspec.yaml @@ -1,6 +1,6 @@ name: firehose description: A tool to automate publishing of Pub packages from GitHub actions. -version: 0.12.0 +version: 0.12.1-wip repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/firehose environment: diff --git a/pkgs/firehose/test_data/golden/comment_breaking.md b/pkgs/firehose/test_data/golden/comment_breaking.md index 84aabe0b..b6ca7d84 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking.md +++ b/pkgs/firehose/test_data/golden/comment_breaking.md @@ -1,4 +1,4 @@ -
+
Breaking changes :warning: diff --git a/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md b/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md index 62ca9598..3ee63bb8 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_breaking_healthchanged.md @@ -1,4 +1,4 @@ -
+
Breaking changes :warning: diff --git a/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md b/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md index 59fda74f..24d59fb5 100644 --- a/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_breaking_ignore_package.md @@ -1,4 +1,4 @@ -
+
Breaking changes :warning: diff --git a/pkgs/firehose/test_data/golden/comment_coverage.md b/pkgs/firehose/test_data/golden/comment_coverage.md index 52d81eeb..16669980 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage.md +++ b/pkgs/firehose/test_data/golden/comment_coverage.md @@ -1,4 +1,4 @@ -
+
Coverage :warning: diff --git a/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md b/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md index 5de5ebe3..aed10095 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_coverage_healthchanged.md @@ -1,4 +1,4 @@ -
+
Coverage :warning: diff --git a/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md b/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md index 46137334..1b09c71e 100644 --- a/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_coverage_ignore_package.md @@ -1,4 +1,4 @@ -
+
Coverage :warning: diff --git a/pkgs/firehose/test_data/golden/comment_leaking.md b/pkgs/firehose/test_data/golden/comment_leaking.md index 4711c9cd..7d889365 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking.md +++ b/pkgs/firehose/test_data/golden/comment_leaking.md @@ -1,4 +1,4 @@ -
+
API leaks :warning: diff --git a/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md b/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md index 4711c9cd..7d889365 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md +++ b/pkgs/firehose/test_data/golden/comment_leaking_healthchanged.md @@ -1,4 +1,4 @@ -
+
API leaks :warning: diff --git a/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md b/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md index 4711c9cd..7d889365 100644 --- a/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md +++ b/pkgs/firehose/test_data/golden/comment_leaking_ignore_package.md @@ -1,4 +1,4 @@ -
+
API leaks :warning: