Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for the short style #1613

Open
4 tasks
munificent opened this issue Dec 6, 2024 · 0 comments
Open
4 tasks

Remove support for the short style #1613

munificent opened this issue Dec 6, 2024 · 0 comments
Labels

Comments

@munificent
Copy link
Member

munificent commented Dec 6, 2024

The formatter is in a transition period from the older "short" formatting style to the new "tall" style. It currently supports both styles and uses the language version of the file to determine which style you get. Eventually, we want to remove support for the old style completely so we no longer need to maintain that code. This issue tracks that.

Here are the tasks to remove the old style:

  • Decide what version of the Dart SDK will no longer support the short style. Coordinate with leads and PMs to decide when we want to remove support.
  • Announce the intent to stop supporting the older style. Send a notification on all the various channels letting users know that the upcoming Dart SDK release will change the formatting of their older language versioned files. Encourage users to preemptively configure their project to use the new style on all of their files to minimize disruption.
  • Remove support for short style. Delete the old AST visitor, Chunk internal representation, line splitter, and short style tests. Rejoice at the simpler, cleaner formatter codebase.
  • Roll it into the Dart SDK.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant