You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expression.asA(Expression other) always wraps the code into parentheses. While this is a good default it is not always necessary. The problem for me is that the generated code triggers the linter rule unnecessary_parenthesis in our CI. Unfortunately dart_style auto fixes does not support the removal of unnecessary parenthesis.
My suggestion would be to have an optional parameter.
the following:
We typically recommend avoiding that type of style lint for generated code. As mentioned in #213 readability is not a goal for the generated output from this package. This is a relatively easy change though, and most of the complexity stays in the calling code deciding what value to pass.
@srawlins do you have any opinions on adding this option?
Expression.asA(Expression other)
always wraps the code into parentheses. While this is a good default it is not always necessary. The problem for me is that the generated code triggers the linter rule unnecessary_parenthesis in our CI. Unfortunately dart_style auto fixes does not support the removal of unnecessary parenthesis.My suggestion would be to have an optional parameter.
the following:
code_builder/lib/src/specs/expression.dart
Lines 68 to 73 in 006790d
becomes
The text was updated successfully, but these errors were encountered: