Cannot call toString() on a list of non-literal expressions

[m0nac0]

Whenever I try to use literalList() and pass non-literal expressions, I get the error:
Not a supported literal type

According to #225 this should be supported, though.

[srawlins]

Please provide a minimal reproduction case. What code do you try to run which produces this error?

[m0nac0]

When I tried to provide the minimal reproduction case, I noticed that the same code I couldn't get to work yesterday seems to work fine today. So it seems to have been some other issue on my side. Thank you nonetheless for responding!

[leonsenft]

I ran into this issue and I think the root cause is LiteralListExpression.toString()'s implementation:

code_builder/lib/src/specs/expression/literal.dart

Line 137 in 743cb0a

String toString() => '[${values.map(literal).join(', ')}]';

It passes each value to literal() which is what throws the reported error:

code_builder/lib/src/specs/expression/literal.dart

Line 35 in 743cb0a

throw UnsupportedError('Not a supported literal type: $literal.');

I encountered this issue rather indirectly via the equalsDart matcher, because it invokes toString() in order to describe a mismatch.

I'm not very familiar with this code base, but I wonder if simply calling toString(), instead of literal(), on each value would be sufficient?