From 2dcbb0551b7fbe897ff7389c84f3a6fe85cb725f Mon Sep 17 00:00:00 2001 From: Jacob MacDonald Date: Wed, 3 Aug 2022 07:07:08 -0700 Subject: [PATCH] stop ignoring no_leading_underscores_for_library_prefixes in build scripts, code_builder does it (#3349) --- build_runner/CHANGELOG.md | 5 +++++ .../lib/src/build_script_generate/build_script_generate.dart | 2 -- build_runner/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/build_runner/CHANGELOG.md b/build_runner/CHANGELOG.md index 0bd8ba49b..1ccd0ec99 100644 --- a/build_runner/CHANGELOG.md +++ b/build_runner/CHANGELOG.md @@ -1,3 +1,8 @@ +## 2.2.1-dev + +- Stop ignoring the no_leading_underscores_for_library_prefixes lint in + generated build scripts, code_builder now does this for you. + ## 2.2.0 - Support global 'runs_before' configuration for builders. This allows users diff --git a/build_runner/lib/src/build_script_generate/build_script_generate.dart b/build_runner/lib/src/build_script_generate/build_script_generate.dart index 4ae48a85c..2282c7799 100644 --- a/build_runner/lib/src/build_script_generate/build_script_generate.dart +++ b/build_runner/lib/src/build_script_generate/build_script_generate.dart @@ -60,8 +60,6 @@ Future _generateBuildScript() async { } content ..writeln('// ignore_for_file: directives_ordering') - ..writeln( - '// ignore_for_file: no_leading_underscores_for_library_prefixes') ..writeln(library.accept(emitter)); return DartFormatter().format(content.toString()); diff --git a/build_runner/pubspec.yaml b/build_runner/pubspec.yaml index 296b80ad7..d469841dc 100644 --- a/build_runner/pubspec.yaml +++ b/build_runner/pubspec.yaml @@ -1,5 +1,5 @@ name: build_runner -version: 2.2.0 +version: 2.2.1-dev description: A build system for Dart code generation and modular compilation. repository: https://github.com/dart-lang/build/tree/master/build_runner