Skip to content
This repository has been archived by the owner on Dec 6, 2017. It is now read-only.

Di depends on dynamic version, even when static version is desired #171

Open
alorenzen opened this issue Aug 19, 2014 · 3 comments
Open

Comments

@alorenzen
Copy link

Right now, src/module.dart imports relector_dynamic.dart, which in turn imports dart:mirrors. (https://github.com/angular/di.dart/blob/master/lib/src/module.dart#L6)

For using the static version of di, we should not depend on dart:mirrors.

Can we remove this dependency from the core code?

@vicb
Copy link
Contributor

vicb commented Aug 19, 2014

Isn't the reflector_dynamic import removed by the module transfomer ?

@alorenzen
Copy link
Author

Ah, so it is. We haven't migrated to transformers yet, and are still using the generator script. This mentions a di_static.dart. Where is that generated?

@vicb
Copy link
Contributor

vicb commented Aug 19, 2014

We haven't migrated to transformers yet, and are still using the generator script

@alorenzen then you should discuss with @pavelgj I think this is what is has done in #169

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants