Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Core-signal doesn't work with Dartium/Chromium.app from SDK 1.13 and above #217

Open
gtaylor20 opened this issue Jan 22, 2016 · 3 comments

Comments

@gtaylor20
Copy link

We have an application that uses core-signals for a couple of custom events. With Dartium/Chromium.app for SDK 1.12.2 and earlier, the signals work just fine. But, as soon as we upgrade to Dartium/Chromium.app for SDK 1.13 or above, they no longer work.

We really want to upgrade to the current release 1.13.2 so that we can use the new @js() and JS-Interop features, but we also need these custom core-signals working.

I have posted a test program that is able to illustrate the problem at https://github.com/gtaylor20/incoming.git

@jakemac53
Copy link
Contributor

Looks like the way custom events are handled changed (specifically the detail field).

@jakemac53
Copy link
Contributor

You could try firing the event from JS as a temporary workaround, something like this:

 this.jsElement.callMethod(
    'fire', ['core-signal', new JsObject.jsify({'name': 'test-notification', 'data': now})]);

@gtaylor20
Copy link
Author

Is there any update on this issue? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants