Renamed option BUILD_TESTING to BUILD_RS_TESTING #223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Necessary since it conflicts with internal cmake/ctest mechanisms (see https://cmake.org/cmake/help/latest/command/enable_testing.html). Thank you @cryptomilk for pointing this out! Signed-off-by: Martin Burri <[email protected]>
LebedevRI
requested changes
Jan 26, 2020
|
Related to this pull request in darktable: darktable-org/darktable#4154 |
|
Setting it where? |
|
Ok, I will talk to @cryptomilk first when he is back from the devconf.cz - I understand too little of cmake to give you a good explanation. Please stay tuned. |
|
You can close this, it is a non-issue :-) |
|
As discussed in darktable-org/darktable#4154 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary since it conflicts with internal cmake/ctest mechanisms (see
https://cmake.org/cmake/help/latest/command/enable_testing.html).
Thank you @cryptomilk for pointing this out!
Signed-off-by: Martin Burri [email protected]