Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use single click to navigate through filmstrip in darkroom #18107

Closed
SammysHP opened this issue Dec 29, 2024 · 8 comments
Closed

Option to use single click to navigate through filmstrip in darkroom #18107

SammysHP opened this issue Dec 29, 2024 · 8 comments
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus scope: UI user interface and interactions

Comments

@SammysHP
Copy link

Is your feature request related to a problem? Please describe.

With v5.0 the behavior of navigation in the filmstrip was changed. Previously you could jump to another image by a single click on an image while in darkroom mode. Now you need to double click, while a single click just changes the selection (but how does it make sense to select multiple images in darkroom mode?).

While editing, I jump back and forth a lot, often skipping images. Thus a simple "prev/next image" shortcut isn't sufficient in my case. The change in v5.0 severely impacted my editing performance, without any (obvious) benefit.

Describe the solution you'd like

I'd like to see an option to bring back the old behavior of changing the current image with a single click in the filmstrip while in darkroom mode. The filmstrip in darkroom mode is special and having a different behavior here does not affect UI consistency.

In my opinion it also does not make sense to show the current selection in the filmstrip while in darkroom mode. Maybe I have been using Darktable wrong for all those years, but the focus in darkroom is on editing a single image at a time, not collection management.

@ralfbrown
Copy link
Collaborator

It's unlikely to be changed, as the change in 5.0 restores old behavior and harmonizes the behavior with the lighttable thumbnail grid and basically every file manager ever.

Selecting images in the filmstrip enables cut&paste of edit histories and the new "synchronize" shortcut on Ctrl-X, as well as no-click star ratings and color marking.

@ralfbrown ralfbrown added the scope: UI user interface and interactions label Dec 29, 2024
@SammysHP
Copy link
Author

SammysHP commented Dec 29, 2024

Selecting images in the filmstrip enables cut&paste of edit histories and the new "synchronize" shortcut on Ctrl-X, as well as no-click star ratings and color marking.

Ahh I see, these are all things I do from the lighttable for better overview. But I assume there are many different valid workflows.

It's unlikely to be changed, as the change in 5.0 restores old behavior and harmonizes the behavior with the lighttable thumbnail grid and basically every file manager ever.

I can't remember that it ever was a double click. (Actually the single click was introduced in 2020 with Darktable 3.2 and now I remember vaguely how I double clicked for a while until I got used to it, sorry.) As I said, I don't see any necessity to have this kind of consistency between lighttable and darkroom as they have different purposes/focus (for me, that is).

Regarding other file managers: This isn't a file manager. It's a navigation method while editing images. For example gThumb has it implemented as I suggested (double click from the lighttable, but single click from the filmstrip).

Also I don't request to change the default behavior, just to add an option to get the old behavior back. Now that v5 is rolling out, I predict that more long time users are confused about this change.


edit: I just wanted to try this, but couldn't find out how it works. Is it only available with keyboard shortcuts?

Selecting images in the filmstrip enables cut&paste of edit histories

@TurboGit
Copy link
Member

As I said, I don't see any necessity to have this kind of consistency between lighttable and darkroom as they have different purposes/focus (for me, that is).

It is needed to be able to do complex selection with click to select ctrl & shift to add to selection using the standard key stroke used in all programs. The consistency here is then important, it was very clumsy to do selection in previous version and this was reported by users, we cannot please everyone :)

Also I don't request to change the default behavior, just to add an option to get the old behavior back.

No luck, this change of selection was hard (yes I mean it, hard to get right) because of the way the filmstrip is handled, so I don't want to see a pref for this as it will require more testing and maintenance.

@TurboGit TurboGit added the controversial this raises concerns, don't move on the technical work before reaching a consensus label Dec 29, 2024
@SammysHP
Copy link
Author

so I don't want to see a pref for this as it will require more testing and maintenance.

Understandable, that's something I have to deal with as well as a software developer. It's just hard for me to see the benefit of the change specifically for the darkroom layout because I haven't found any use case or example of a workflow. Even the documentation appears to be outdated and not helpful in this regard.

@TurboGit
Copy link
Member

I'm pretty sure you'll get used to it soon :)

@SammysHP
Copy link
Author

Yeah, probably. Still I'm curious to learn more about the new possibilities. Can you link me any resources how to work with the filmstrip in the darkroom layout to utilize the selection feature?

@TurboGit
Copy link
Member

TurboGit commented Dec 30, 2024

Already answered in another thread:

  • click single selection
  • ctrl+click add one picture to selection
  • shift+click add range from last selected picture to selection

As for all programs around and also the lighttable, no surprise, no magic, no guessing!

@SammysHP
Copy link
Author

SammysHP commented Dec 30, 2024

Yes, I'm familiar with selecting multiple images. But nobody was able to tell me what to do with the selection in the darkroom layout.


From above:

Selecting images in the filmstrip enables cut&paste of edit histories and the new "synchronize" shortcut on Ctrl-X, as well as no-click star ratings and color marking.

I guess this is all done with keyboard shortcuts, right? Such features are hard to discover, a better description in the documentation with an example would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controversial this raises concerns, don't move on the technical work before reaching a consensus scope: UI user interface and interactions
Projects
None yet
Development

No branches or pull requests

3 participants