Nikon Z6 style: duplicate filmic

[kofa73]

Describe the bug

@ralfbrown
The style (darktable_Nikon_Z 6.dtstyle) has 2 instances of filmic rgb, both active.
https://discuss.pixls.us/t/darktable-5-0-0-released/47122/95
https://discuss.pixls.us/t/darktable-5-0-0-released/47122/101

<style>
    <plugin>
        <num>14</num>
        <module>6</module>
        <operation>filmicrgb</operation>
        <!-- params etc. omitted -->
    </plugin>

    <!-- more plugins -->

    <plugin>
        <num>9</num>
        <module>6</module>
        <operation>filmicrgb</operation>
        <!-- params etc. omitted -->
    </plugin>
</style>

Steps to reproduce

Apply the style, see 2 filmic instances.

Expected behavior

No response

Logfile | Screenshot | Screencast

No response

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Linux

What is the version of your OS?

OS-independent

Describe your system?

No response

Are you using OpenCL GPU in darktable?

None

If yes, what is the GPU card and driver?

No response

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

No response

[ralfbrown]

Probably forgot to compress history before saving that style and then got hit with the multiple instance creation bug.

The styles in the darktable camera styles hierarchy can be edited just like any user-created style (deleted styles get reimported, but there is no other synchronization with the built-in style files). So this is fixable by the user until a corrected style is merged. The latter would require the user to first delete the bad style unless we add code to import all styles, not just missing ones, if there is a known update to previously-shipped styles.

To remove the second instance of filmic from the style, select the style in the styles module by single clicking. Then click Edit, uncheck the lower instance of filmic, and click Save.

Note to self: Nikon D600 style has the same issue; all other Nikon and Canon styles are OK.

[kap5535]

I believe that the same issue exists with Nikon D500, D750 and D850.

The darktable camera styles turn off the sigmoid and base curve modules and then turn on the filmic rgb module if a scene-referred (sigmoid) workflow is selected in darktable processing preferences.

If a scene-referred (filmic rgb) workflow is selected in darktable processing preferences then you you end up with two selected instances of the filmic rgb module.