Skip to content

Styles module: rename 'remove' button to 'delete', reword tooltip #18086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kofa73 opened this issue Dec 27, 2024 · 3 comments
Open

Styles module: rename 'remove' button to 'delete', reword tooltip #18086

kofa73 opened this issue Dec 27, 2024 · 3 comments
Labels
no-issue-activity scope: UI user interface and interactions

Comments

@kofa73
Copy link
Contributor

kofa73 commented Dec 27, 2024

Is your feature request related to a problem? Please describe.
Inspired by https://discuss.pixls.us/t/dt-5-0-0-how-to-un-apply-a-style/47252/: the user misunderstood the function of the remove button in the styles module, thinking it would undo applying the style.

Describe the solution you'd like

  • Rename the button to delete.
  • Update the tooltip: removes the selected styles in the list abovedeletes the styles selected in the list above (replace the verb, and reword the part about the selection)

This would make it consistent with e.g. the tagging module, where the command (in the pop-up menu) is called delete tag:
image

Alternatives
Leave as-is.

I'm happy to add the code and update the manual if this is accepted.

@ralfbrown ralfbrown added the scope: UI user interface and interactions label Dec 27, 2024
@TurboGit
Copy link
Member

But delete on the style module is wrong as the style is removed from the module but it is kept on disk. So delete will be confusing.

@kofa73
Copy link
Contributor Author

kofa73 commented Dec 27, 2024

OK, thanks for the clarification. How about adjusting the tooltip?

removes the selected styles in the list aboveremove the styles selected in the list above from the database, without deleting

or

removes the selected styles in the list aboveremove the styles selected in the list above from the database

That wording is consistent with remove for images: remove images from the image library, without deleting.

Copy link

This issue has been marked as stale due to inactivity for the last 60 days. It will be automatically closed in 300 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity scope: UI user interface and interactions
Projects
None yet
Development

No branches or pull requests

3 participants