darktable crashes when deleting new instance

[pepi-55]

Describe the bug

When a new instance is made in darktable (5.0 for instance the tone equalizer ) and this instance is deleted using ' right klick - delete' , darktable crashes
I'm on a Mac mini apple silicon m2 an d macOS 15.1.1

Steps to reproduce

Expected behavior

should not crash

Logfile | Screenshot | Screencast

darktable-2024-12-23-161628.pdf

Commit

No response

Where did you obtain darktable from?

downloaded from www.darktable.org

darktable version

5.0.0

What OS are you using?

Mac

What is the version of your OS?

15.1.1

Describe your system?

Mac mini 16 g ram
M2
apple silicon

Are you using OpenCL GPU in darktable?

Yes

If yes, what is the GPU card and driver?

build in

Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip

[zisoft]

I can reproduce.
If the module instance has the focus (by touching one of the controls in it) and then the instance is deleted, dt crashes in develop/imageop.c, line 536:

darktable/src/develop/imageop.c

Lines 532 to 538 in 8e95981

	// we remove the plugin effectively
	if(!dt_iop_is_hidden(module))
	{
	dt_iop_gui_cleanup_module(module);
	gtk_widget_grab_focus(dt_ui_center(darktable.gui->ui));
	}

Easily reproducible with the exposure module:

• create a new instance of the exposure module
• slightly touch the exposure slider
• delete the instance

[zisoft]

The crash is effectively avoided by swapping the two lines:

  // we remove the plugin effectively
  if(!dt_iop_is_hidden(module))
  {
    gtk_widget_grab_focus(dt_ui_center(darktable.gui->ui));
    dt_iop_gui_cleanup_module(module);
  }