Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

residual layer in retouch wavlet decomposition differs between opencl and cpu #17936

Open
MStraeten opened this issue Dec 3, 2024 · 5 comments
Labels
bug: pending someone needs to start working on that priority: low core features work as expected, only secondary/optional features don't reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Milestone

Comments

@MStraeten
Copy link
Collaborator

MStraeten commented Dec 3, 2024

Describe the bug

deactivating gpu processing results in a darkened residual layer

opencl on:
image

opencl off:
image

Steps to reproduce

  1. show residual layer in retouch
  2. enable/disable opencl

Where did you obtain darktable from?

self compiled

darktable version

windows: 4.9.0+1227gbb12aceef5
macos: 4.9.0+1229
gfabbd1d450

What OS are you using?

Windows
also reproducible on macos

What is the version of your OS?

Win 10, MacOS1 5

Describe your system?

Prozessor 13th Gen Intel(R) Core(TM) i7-1365U 1.80 GHz
Installierter RAM 32,0 GB (31,7 GB verwendbar)

apple m1max

Are you using OpenCL GPU in darktable?

Yes

@jenshannoschwalm
Copy link
Collaborator

Can you say if this is something new.

@MStraeten
Copy link
Collaborator Author

unfortunately not, reproducible even with my 4.8.1 build ...

@jenshannoschwalm
Copy link
Collaborator

unfortunately not, reproducible even with my 4.8.1 build ...

In a way - good for me as i was sure not introducing a regression by late code mods.

@jenshannoschwalm jenshannoschwalm added priority: low core features work as expected, only secondary/optional features don't reproduce: confirmed a way to make the bug re-appear 99% of times has been found bug: pending someone needs to start working on that labels Dec 4, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.2 milestone Dec 4, 2024
@MStraeten
Copy link
Collaborator Author

MStraeten commented Dec 4, 2024

side note: the different handling on cpu path seems to be consistent with the behaviour described in #8894 (but there it's consistent dark for gpu and cpu path)

a wavelet decomposition in gimp is similar to the gpu behaviour

@jenshannoschwalm
Copy link
Collaborator

I checked the code and it's at least not something obvious. So no fix for 5.0 unfortunately. We should come back to this and your other issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that priority: low core features work as expected, only secondary/optional features don't reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Projects
None yet
Development

No branches or pull requests

2 participants