Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rotate and perspective : not working properly if image was flipped before #11640

Open
pehar1 opened this issue Apr 26, 2022 · 6 comments
Open
Labels
bug: pending someone needs to start working on that reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Milestone

Comments

@pehar1
Copy link

pehar1 commented Apr 26, 2022

Did you buy darktable from an application store ?
no, self build from git master

Describe the bug/issue
One of the correction modes of rotate and perspective module (manually draw structure lines) does not work if the image has been horizontally flipped before.

To Reproduce

  1. Select arbitrary image in lighttable
  2. Go to darkroom
  3. Reset history -> only minimal set of modules applied
  4. Go to orientation module, select transform -> flip horizontally
  5. Go to rotate and perspective module
  6. Select structure -> manually draw structure lines
  7. Draw 2 or more approximately vertical lines
  8. Select fit -> automatically correct for vertical perspective distortion
  9. See error message : not enough structure for automatic correction, no correction applied

Expected behavior
Perspective correction should be applied in step 8 even if image was flipped before, no error message

Which commit introduced the error
unknown

Platform
darktable version : 3.9.0+1285-gab83b180b
OS : Linux 5.4.0-109-generic / Ubuntu 20.04.4 LTS
Memory : MemTotal: 65780936 kB
Graphics Card : Product Name : NVIDIA GeForce RTX 2060
Graphics Card : Driver Version : 470.103.01
OpenCL installed : Device OpenCL C Version OpenCL C 1.2
OpenCL activated : yes
Xorg : Version: 1:7.7+19ubuntu14
Desktop : LXQt
GTK+ : 3.24.20
gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0
CMAKE_BUILD_TYPE : release

  • Can you reproduce with another darktable version(s)? did not try
  • Can you reproduce with a RAW or Jpeg or both? only worked with raw
  • Are the steps above reproducible with a fresh edit (i.e. after discarding history)? yes
@elstoc
Copy link
Contributor

elstoc commented Apr 26, 2022

Seems similar to #11614

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@pehar1
Copy link
Author

pehar1 commented Jun 26, 2022

Checked with 3.9.0+1780~gd0fa1f606, issue is still present.

@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@Nilvus Nilvus added bug: pending someone needs to start working on that and removed no-issue-activity labels Aug 26, 2022
@github-actions
Copy link

This issue did not get any activity in the past 60 days and will be closed in 365 days if no update occurs. Please check if the master branch has fixed it and report again or close the issue.

@ralfbrown
Copy link
Collaborator

Confirmed for 4.3.0+975. Based on the colors given to the lines, R&P confuses horizontal and vertical on lines drawn while the Orientation module is set to "flip horizontally", whether they are drawn manually or auto-detected. Moving Orientation below R&P eliminates this interaction.

@TurboGit TurboGit added this to the 4.4 milestone Mar 5, 2023
@TurboGit TurboGit added reproduce: confirmed a way to make the bug re-appear 99% of times has been found and removed no-issue-activity labels Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending someone needs to start working on that reproduce: confirmed a way to make the bug re-appear 99% of times has been found
Projects
None yet
Development

No branches or pull requests

5 participants