Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the conversation API #646

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Nov 5, 2024

Description

Adds support for the conversation API.

Currently imports github.com/dapr/dapr from master.
Overrides dapr with a commit reference from master. This will need to be reverted once a release is cut.

Issue reference

Please reference the issue this PR will close: #645

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 61.45%. Comparing base (6c59092) to head (d4f306e).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
client/conversation.go 0.00% 63 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
- Coverage   62.52%   61.45%   -1.07%     
==========================================
  Files          56       57       +1     
  Lines        4139     4268     +129     
==========================================
+ Hits         2588     2623      +35     
- Misses       1425     1517      +92     
- Partials      126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee linked an issue Nov 5, 2024 that may be closed by this pull request
@mikeee mikeee changed the title Conversation api dev Add support for the conversation API Nov 5, 2024
@mikeee mikeee marked this pull request as ready for review November 21, 2024 12:41
@mikeee mikeee requested review from a team as code owners November 21, 2024 12:41
@yaron2 yaron2 merged commit dce63f1 into dapr:main Nov 27, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversation API support
2 participants