Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement distributed scheduler building block #562

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented May 8, 2024

Description

  • Registers a new alpha appcallback server
  • Implements an empty onbulktopicevent handler that will panic
  • Implements the alpha job api and appcallback registration
  • Misc changes to the examples - fixing conflicts with the default scheduler port
  • Updates the validation workflow to enable building from custom commits using events

Issue reference

Please reference the issue this PR will close: #561

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 49.31507% with 37 lines in your changes missing coverage. Please review.

Project coverage is 61.72%. Comparing base (27248ba) to head (678c855).
Report is 19 commits behind head on main.

Files Patch % Lines
service/grpc/scheduling.go 0.00% 21 Missing ⚠️
client/scheduling.go 78.37% 4 Missing and 4 partials ⚠️
service/http/scheduling.go 0.00% 6 Missing ⚠️
service/grpc/topic.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   58.04%   61.72%   +3.68%     
==========================================
  Files          55       56       +1     
  Lines        3568     3420     -148     
==========================================
+ Hits         2071     2111      +40     
+ Misses       1375     1184     -191     
- Partials      122      125       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee force-pushed the feat-dist-scheduler branch 13 times, most recently from 43c8782 to 5fa320b Compare May 8, 2024 21:27
@mikeee mikeee added this to the v1.11 milestone May 11, 2024
@mikeee mikeee added enhancement-runtime-dependency New feature or request due to a runtime feature P0 labels May 11, 2024
@mikeee mikeee force-pushed the feat-dist-scheduler branch 8 times, most recently from 30868ea to ff27c4d Compare May 17, 2024 16:34
@mikeee mikeee force-pushed the feat-dist-scheduler branch 4 times, most recently from 2e9a134 to d9e218f Compare May 20, 2024 11:49
@mikeee mikeee mentioned this pull request May 28, 2024
43 tasks
@mikeee mikeee force-pushed the feat-dist-scheduler branch 2 times, most recently from 83bb77c to 5018005 Compare May 29, 2024 15:10
@mikeee mikeee force-pushed the feat-dist-scheduler branch 5 times, most recently from b21d694 to a52c991 Compare June 13, 2024 12:31
@yaron2
Copy link
Member

yaron2 commented Jul 9, 2024

What's needed for this to go out of draft?

@mikeee
Copy link
Member Author

mikeee commented Jul 9, 2024

What's needed for this to go out of draft?

I've rerun this and the jobs aren't being invoked (not sure what has changed since the last successful runs a month ago). I'll need to take a look at this tomorrow with fresh eyes

@mikeee
Copy link
Member Author

mikeee commented Jul 10, 2024

The answer was right there in the error as always... needed to register a new alpha callbackserver since this was refactored upstream.

@mikeee mikeee marked this pull request as ready for review July 10, 2024 10:08
@mikeee mikeee requested review from a team as code owners July 10, 2024 10:08
@mikeee mikeee changed the title [WIP] - Implement distributed scheduler building block Implement distributed scheduler building block Jul 10, 2024
@mikeee mikeee force-pushed the feat-dist-scheduler branch 3 times, most recently from 58e56c0 to 89a90e1 Compare July 10, 2024 15:46
Signed-off-by: mikeee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement-runtime-dependency New feature or request due to a runtime feature P0
Projects
Status: Needs Owner
Development

Successfully merging this pull request may close these issues.

Implement distributed scheduler building block (alpha)
2 participants