Implementing .NET Dapr SDK-wide nullability annotations #1269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a WIP PR, but opening it so I don't forget about it locally. In short, this implements the
<nullable>enable</nullable>attribute across all .NET Dapr SDKs both on the type level and with a few changes to the logic as necessary to facilitate the changes.I couldn't leave the challenge posted here unanswered.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #523
That said, this isn't applicable only to Dapr.Client but aims to be applicable across the entire Dapr .NET SDK. While Dapr.Client is completed and builds right now, ASP.NET Core support is nearly completed, Actors is underway and I just noticed that both Dapr.Extensions.Configuration and Dapr.Workflow already implement this, so already done there.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: