Skip to content

Conversation

@sclarke81
Copy link
Contributor

@sclarke81 sclarke81 commented Oct 28, 2024

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • [x ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [x ] Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Redis is used in the Workflows Quickstarts, but Redis isn't recommended for use in production (for Workflows). Added a note to the Quickstarts page to highlight this. I've raised this in response to discussions with Oli and Whit on Discord.

@sclarke81 sclarke81 requested review from a team as code owners October 28, 2024 10:54
Copy link
Contributor

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick typo fix - thank you!

…start.md

Co-authored-by: Hannah Hunter <[email protected]>
Signed-off-by: Stephen Clarke <[email protected]>
@sclarke81
Copy link
Contributor Author

quick typo fix - thank you!

Good spot, thank you!

@sclarke81 sclarke81 requested a review from hhunter-ms October 30, 2024 12:13
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhunter-ms hhunter-ms merged commit 639362e into dapr:v1.14 Oct 31, 2024
7 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @sclarke81 Thank you Stephen!

@holopin-bot
Copy link

holopin-bot bot commented Dec 3, 2024

Congratulations @sclarke81, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm48768wn19040cjullx9ko4f

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants