Update event API, editing series should reflect in changed date. DDFHER-132 #1773
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ER-132 As we use inheritance, we want an updated series to also reflect in the updatedAt API property. We could implement this, by programmatically saving all instances when the series is saved, but this may have unforseen consequences, as it is running against the Drupal system. Instead, we'll look up the instance and series changed dates, and take which ever is newer.
kasperbirch1
approved these changes
Nov 19, 2024
kasperg
reviewed
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reload.atlassian.net/browse/DDFHER-132
As we use inheritance, we want an updated series to also reflect in the updatedAt API property.
We could implement this, by programmatically saving all instances when the series is saved, but this may have unforseen consequences, as it is running against the Drupal system.
Instead, we'll look up the instance and series changed dates, and take which ever is newer.
If you want to test it, you can try to edit both a series and an instance, and see that the changes are reflected in
updatedAtproperty at/api/v1/events