DDFHER-83 - Update Cypress fixtures to reflect the new /holdingsLogistics/v1 API
#1761
+2,372
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFHER-83-implementer-nyt-beholdnings-endpoint
branch
from
c1a4bd6
to
6ac2ace
Compare
kasperbirch1
changed the title
/holdingsLogistics/v1 API
kasperbirch1
force-pushed
the
DDFHER-83-implementer-nyt-beholdnings-endpoint
branch
from
6ac2ace
to
7fba15b
Compare
kasperg
approved these changes
Nov 18, 2024
kasperbirch1
force-pushed
the
DDFHER-83-implementer-nyt-beholdnings-endpoint
branch
from
7fba15b
to
de27a52
Compare
In the dpl-react project, we migrated from `/holdings/v3` to `/holdingsLogistics/v1`. Refer to the pull request: danskernesdigitalebibliotek/dpl-react#1443. This change caused the `user-journey` Cypress test to fail.
kasperbirch1
force-pushed
the
DDFHER-83-implementer-nyt-beholdnings-endpoint
branch
from
de27a52
to
91d3545
Compare
kasperbirch1
force-pushed
the
DDFHER-83-implementer-nyt-beholdnings-endpoint
branch
from
91d3545
to
e555360
Compare
The previous configuration was using release `2024.48.0`, but it must be switched back to `develop` to include the `/holdingsLogistics/v1` update. This adjustment is essential for other developers' work until the next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFHER-83
Description
In the dpl-react project, we migrated from the
/holdings/v3endpoint to the new/holdingsLogistics/v1API version. For more details, refer to the associated pull request: danskernesdigitalebibliotek/dpl-react#1542.As a result of this change, the
user-journeyCypress test was failing due to the outdated API endpoint being used in the test. This pull request updates the test to reflect the new/holdingsLogistics/v1API, ensuring it works as expected with the updated backend.