Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less frequent translation importing on development sites. #1561

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rasben
Copy link
Contributor

@rasben rasben commented Sep 13, 2024

Remove reference to inactive PR environment

Run translation import less frequently.

In an attempt to make caching more stable, and to match the rate at
which translations actually happen.

Copy link
Collaborator

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against these changes, but there some things to consider:

  • The DDF team need to be aware of the fact that they in worst case will have to wait 12 hours before they can will be able to see changes made in the PO editor
  • We have locale-check/-update in the post-rollout hook which makes sure that new translations are being imported. Why don't we have config-translations imported as well? This is not connected to your changes, but I just wonder - and we might as well fix that bit

@spaceo spaceo removed their assignment Oct 9, 2024
@rasben
Copy link
Contributor Author

rasben commented Nov 19, 2024

About your considerations:

  1. I think in reality, this is not a problem for our day-to-day work. I can only speak for myself, but, when it comes to translations, I don't really think about it when they're missing as part of development and testing, as that is DDF's job to handle. I just need to make sure things are translatable

  2. Good point, but, I think it's outside the scope of this PR. If someone actually needs it in the future, I'm sure they can introduce it.

In an attempt to make caching more stable, and to match the rate at
which translations actually happen.
@rasben rasben changed the title Tweaking lagoon yml Less translation importing on development sites. Nov 26, 2024
@rasben rasben changed the title Less translation importing on development sites. Less frequent translation importing on development sites. Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants