Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start coverband from outside the Rails project directory #99

Closed
ThomasOwens opened this issue Mar 5, 2018 · 3 comments
Closed

Comments

@ThomasOwens
Copy link
Contributor

I noticed a few things, all in lib/coverband.rb.

First, CONFIG_FILE is hard coded to a relative path. This is all well and good until you try to invoke a Rails application from outside Rails.root. From what I can tell, Coverband is looking for the CONFIG_FILE relative to the location where you run your script. Although I can set my working directory before starting the application, this doesn't seem like it should be necessary.

I also noticed that the self.configure method takes in a file argument, but it is unused. It appears like it should allow a caller to, instead of passing in a block, pass in a path to a configuration file instead. This would add a great deal of flexibility into users of Coverband by allowing them to choose a location to put the configuration file, instead of requiring it to be in './config/coverband.rb'.

@ThomasOwens
Copy link
Contributor Author

I've opened one possible solution as a PR: #100

@danmayer
Copy link
Owner

excellent, I will address this and help get that merged in after I get the long in progress Coverband 2.0 PR released. Thanks so much for the interest and support.

#107

@danmayer
Copy link
Owner

resolved closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants