removed unnecessary checks not detected by tooling

danmar · Nov 29, 2024 · 2ee9352 · 2ee9352
1 parent 16d250e
commit 2ee9352
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/lib/cppcheck.cpp b/lib/cppcheck.cpp
@@ -1103,8 +1103,8 @@ void CppCheck::checkNormalTokens(const Tokenizer &tokenizer)
 
     if (mSettings.useSingleJob() || !mSettings.buildDir.empty()) {
         // Analyse the tokens..
-
-        if (CTU::FileInfo * const fi1 = CTU::getFileInfo(tokenizer)) {
+        {
+            CTU::FileInfo * const fi1 = CTU::getFileInfo(tokenizer);
             if (!mSettings.buildDir.empty())
                 mAnalyzerInformation.setFileInfo("ctu", fi1->toString());
             if (mSettings.useSingleJob())

diff --git a/lib/templatesimplifier.cpp b/lib/templatesimplifier.cpp
@@ -1346,7 +1346,7 @@ void TemplateSimplifier::simplifyTemplateAliases()
                     const Token * const fromStart = args[argnr].first;
                     const Token * const fromEnd   = args[argnr].second->previous();
                     Token *temp = TokenList::copyTokens(tok1, fromStart, fromEnd, true);
-                    const bool tempOK(temp && temp != tok1->next());
+                    const bool tempOK(temp != tok1->next());
                     tok1->deleteThis();
                     if (tempOK)
                         tok1 = temp; // skip over inserted parameters

diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -2152,9 +2152,6 @@ void Tokenizer::simplifyTypedefCpp()
 
                         tok2 = TokenList::copyTokens(tok2, argStart, argEnd);
                         if (inTemplate) {
-                            if (!tok2)
-                                syntaxError(nullptr);
-
                             tok2 = tok2->next();
                         }