Fixes multiple issues #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To embed an image use the following syntax:  where … is the image data encoded in base64. The syntax also works with other file format (png, jpg, etc.)
elarivie
changed the title
* elarivie/master: Set maxbuffer length to Infinity to avoid stdout maxBuffer exceeded fix danielgtaylor#44 Removed hardcoded path to tmp, now uses os library to get it. Add support for embeded image with data uri Added missing description of response to the template Randomize temp file name to avoid race condition fix danielgtaylor#17 fix danielgtaylor#24 fix danielgtaylor#42
* hg-jt/fix/57-image-handling: Fix for danielgtaylor#57: filePath is now passed to resolveImages.
|
👍 |
|
Any chance to see this merged? |
|
Any Movement on this? |
|
@danielgtaylor Any chance of seeing this merged? Previewing in Atom fails on every other change. |
|
@danielgtaylor any status for this MR? Seems it can fix annoying "/tmp/atom.apib" issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains many fixes
Temp file issues:
fix #17
fix #24
fix #42
Max Buffer size issue:
fix #44
Other unreported issues which are fix:
No description for response section
Not possible to embed image with data-uri
Well now it is possible (and its really useful)
To embed an image use the following syntax:
where … is the image data encoded in base64.
The syntax also works with other file format (png, jpg, etc.)