Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a switch whether to draw limit line's labels. default is true #887

Merged
merged 1 commit into from
May 22, 2016

Conversation

liuxuan30
Copy link
Member

add a switch whether to draw limit line's labels. default is true

@danielgindi
Copy link
Collaborator

There's a typo there :-)

Anyway, by default the label is not rendered, as it is empty. So I'm guessing if the user has set a label - it means he wants it to draw. Am I missing something here?

@liuxuan30 liuxuan30 force-pushed the limitLineDrawLableEnabled branch 3 times, most recently from 580c887 to c946a0f Compare April 11, 2016 02:49
@liuxuan30
Copy link
Member Author

typo fixed and squashed.
Normally what you said is true. But I did this because our UE has a sick demand... the label is there, and user decides whether to display it. I have to store the label somewhere if I don't have a switch. It may help others

@danielgindi danielgindi merged commit 035bf11 into ChartsOrg:master May 22, 2016
@liuxuan30 liuxuan30 deleted the limitLineDrawLableEnabled branch January 16, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants