Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch is not compiling #879

Closed
amitvyawahare opened this issue Mar 25, 2016 · 8 comments
Closed

Master branch is not compiling #879

amitvyawahare opened this issue Mar 25, 2016 · 8 comments

Comments

@amitvyawahare
Copy link

When I download ios-charts from master branch, I am not able to compile. I am getting 26 errors(Expected expression in list of expressions) but when I download ios-chart project from floatXAxis branch I am able to compile/run fine.

@liuxuan30
Copy link
Member

I tried, I was able to compile it. So should be your project issues. Try clean and rebuild again.
BTW, you should follow what the errors are saying and you know how to fix it.

@sitmo
Copy link

sitmo commented Mar 30, 2016

I'm having the exact same problem with the master branch and a fresh install: 26x Expected expression in list of expressions. Any idea what can be causing this?

@danielgindi
Copy link
Collaborator

Which version of Xcode are you using?

@sitmo
Copy link

sitmo commented Mar 30, 2016

I think either 72. or 7.3, ..I'll post the details later when I have access to my machine. Is there any other info I can collect and share that might be helpful?
I'm building for iOS 8.0 using swift 2.1.1

@sitmo
Copy link

sitmo commented Mar 30, 2016

Here is more info:

XCode Version 7.2.1

CompileSwift normal arm64 <snip>/Charts/Classes/Data/Implementations/Standard/CombinedChartData.swift
 ...
<snip>/Charts/Classes/Jobs/AnimatedViewPortJob.swift:73:64: error: expected expression in list of expressions
        _displayLink = NSUIDisplayLink(target: self, selector: #selector(AnimatedViewPortJob.animationLoop))
                                                               ^
<snip>/Charts/Classes/Jobs/AnimatedViewPortJob.swift:73:64: error: expected ',' separator
        _displayLink = NSUIDisplayLink(target: self, selector: #selector(AnimatedViewPortJob.animationLoop))
                                                               ^
                                                              ,
<snip>/Charts/Classes/Jobs/AnimatedViewPortJob.swift:73:64: error: expected expression in list of expressions
        _displayLink = NSUIDisplayLink(target: self, selector: #selector(AnimatedViewPortJob.animationLoop))
                                                               ^
<snip>/Charts/Classes/Jobs/AnimatedViewPortJob.swift:73:64: error: expected ',' separator
        _displayLink = NSUIDisplayLink(target: self, selector: #selector(AnimatedViewPortJob.animationLoop))
                                                               ^
                                                              ,
<snip>/Charts/Classes/Charts/BarLineChartViewBase.swift:120:80: error: expected expression in list of expressions
        _tapGestureRecognizer = NSUITapGestureRecognizer(target: self, action: #selector(BarLineChartViewBase.tapGestureRecognized(_:)))
                                                                               ^
<snip>/Charts/Classes/Charts/BarLineChartViewBase.swift:120:80: error: expected ',' separator
        _tapGestureRecognizer = NSUITapGestureRecognizer(target: self, action: #selector(BarLineChartViewBase.tapGestureRecognized(_:)))
                                                                               ^
                                                                              ,
<snip>/Charts/Classes/Charts/BarLineChartViewBase.swift:120:80: error: expected expression in list of expressions
        _tapGestureRecognizer = NSUITapGestureRecognizer(target: self, action: #selector(BarLineChartViewBase.tapGestureRecognized(_:)))
                                                                               ^
<snip>/Charts/Classes/Charts/BarLineChartViewBase.swift:120:80: error: expected ',' separator
        _tapGestureRecognizer = NSUITapGestureRecognizer(target: self, action: #selector(BarLineChartViewBase.tapGestureRecognized(_:)))
                                                                               ^
                                                                              ,

@danielgindi
Copy link
Collaborator

Xcode is moved to Swift 2.1 now. You need to install Xcode 7.3.

@sitmo
Copy link

sitmo commented Mar 30, 2016

Excellent, upgrading to Xcode to 7.3 solved there errors. Thanks for the help.

I now have Swift 2.2 with XCode 7.3. Previously I had XCode 7.2.1, Swift version 2.1.1, so I think the minimal required Swift version is 2.2?

@danielgindi
Copy link
Collaborator

Yeah I guess you are right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants