Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _chart in CombinedChartRenderer internal #446

Closed
AlBirdie opened this issue Oct 5, 2015 · 3 comments
Closed

Make _chart in CombinedChartRenderer internal #446

AlBirdie opened this issue Oct 5, 2015 · 3 comments

Comments

@AlBirdie
Copy link
Contributor

AlBirdie commented Oct 5, 2015

Hi guys,

would it be possible to change the _chart property in the CombinedChartRenderer from private, to internal?

That would assist extendability a lot. I'm constantly forgetting to change this once I've updated to the new master branch.

Cheers!
@danielgindi
Copy link
Collaborator

No problem make a PR and I can merge it quickly using a message in the
Telegram bot ;)

‏בתאריך יום שני, 5 באוקטובר 2015, AlBirdie [email protected] כתב:

Hi guys,

would it be possible to change the _chart property in the
CombinedChartRenderer from private, to internal?

That would assist extendability a lot. I'm constantly forgetting to change
this once I've updated to the new master branch.

Cheers!

—
Reply to this email directly or view it on GitHub
#446.

@AlBirdie
Copy link
Contributor Author

AlBirdie commented Oct 5, 2015

Awesome! ETA tomorrow morning! 👍

@AlBirdie
Copy link
Contributor Author

AlBirdie commented Oct 9, 2015

Sorry, couldn't make it yet. But this is on my to do list monday morning!

@AlBirdie AlBirdie mentioned this issue Oct 15, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielgindi @AlBirdie