Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxRecordCount don't wok #424

Closed
arkadiusz-wolanski opened this issue Sep 23, 2020 · 0 comments
Closed

MaxRecordCount don't wok #424

arkadiusz-wolanski opened this issue Sep 23, 2020 · 0 comments
Assignees
Labels
accepted Issue has been accepted and inserted in a future milestone
Milestone

Comments

@arkadiusz-wolanski
Copy link

Hi,

the parameter MaxRecordCount for the Method SelectRQL doesn't work, it is ignored by the Method InternalSelectRQL:

function TMVCActiveRecord.InternalSelectRQL(const RQL: string; const MaxRecordCount: Integer): TMVCActiveRecordList;
var
  lSQL: string;
begin
  lSQL := SQLGenerator.CreateSQLWhereByRQL(RQL, GetMapping);
  LogD(Format('RQL [%s] => SQL [%s]', [RQL, lSQL]));
  Result := Where(TMVCActiveRecordClass(Self.ClassType), lSQL, []);
end;

If you use this Method for a huge Table, it delivers all records.

@danieleteti danieleteti self-assigned this Sep 30, 2020
@danieleteti danieleteti added the accepted Issue has been accepted and inserted in a future milestone label Sep 30, 2020
@danieleteti danieleteti added this to the 3.2.1-carbon milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue has been accepted and inserted in a future milestone
Projects
None yet
Development

No branches or pull requests

2 participants