Added check for CMAKE_SKIP_INSTALL_RULES #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake's FetchContent module allows people to include your library in their project directly without using an external library manager (ex. vcpkg or conan). Here is an example for doing that:
The only issue with using
FetchContent
is that the cli library will attempt to add install steps regardless of it is the main project or not. CMake allows you to disable the install steps by temporarily setting theCMAKE_SKIP_INSTALL_RULES
variable toON
, but that makes CMake generate a nasty warning message:This is a known issue with CMake (issue #22561) which does not appear like it will be fixed anytime soon. The current fix for
FetchContent
users is to guard a library's install steps with a check forCMAKE_SKIP_INSTALL_RULES
:This pull request adds that check which allows the library to be integrated using
FetchContent
without having additional warning messages appear.