Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Global viewGenerator not been applied to the nodes #130

Closed
LonelyPrincess opened this issue Oct 13, 2018 · 2 comments
Closed

🐛 Global viewGenerator not been applied to the nodes #130

LonelyPrincess opened this issue Oct 13, 2018 · 2 comments
Assignees
@LonelyPrincess
Labels
bug Hacktoberfest Hacktoberfest label

Comments

@LonelyPrincess
Copy link
Collaborator

LonelyPrincess commented Oct 13, 2018 •
edited
Loading

The PR #103 changes introduced in the latest release (2.0.0-rc1) do seem to have a bug when being applied to real projects. If the user defines a viewGenerator in the config object, its value is completely ignored and the default view is used instead.

It seems as if the Node object receives viewGenerator as an undefined value, instead of receiving the generator function defined by the user in the config object. Things work fine if the viewGenerator is defined at node level, though.

For some reason, this error does not happen in the Sandbox example, which is why this issue wasn't detected before merging the feature into the main branch.
@LonelyPrincess LonelyPrincess self-assigned this Oct 13, 2018
@LonelyPrincess
Copy link
Collaborator Author

LonelyPrincess commented Oct 13, 2018 •
edited
Loading

As the author of the changes, I'll make myself responsible for this and upload a fix for it ASAP. Sorry for the inconvenience! 😞

@LonelyPrincess LonelyPrincess mentioned this issue Oct 13, 2018
Merged
@danielcaldas
Copy link
Owner

Closing with #131

@LonelyPrincess LonelyPrincess mentioned this issue Oct 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LonelyPrincess LonelyPrincess

Labels
bug Hacktoberfest Hacktoberfest label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielcaldas @LonelyPrincess