Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ecto 2.0 #10

Closed
bgeihsgt opened this issue May 16, 2016 · 4 comments
Closed

Support for Ecto 2.0 #10

bgeihsgt opened this issue May 16, 2016 · 4 comments

Comments

@bgeihsgt
Copy link

Ecto 2.0 is in RC right now and should be releasing soon. Cloak is pinned to Ecto 1.1 right now. It'd be great to have Cloak support for 2.0 given we want to move our app to 2.0 soon. Thanks!

@Mrjaco12
Copy link

I did a brief look and I don't think that cloak is actually dependent on any ecto < 2.0 features so it should just be a matter of updating the dependency.

@danielberkompas
Copy link
Owner

@bgeihsgt @Mrjaco12 Doesn't the {:ecto, ">= 1.0.0"} version requirement cover Ecto 2.0 already? Since Cloak doesn't require any Ecto 2.0 features, I don't want to prevent people from using it if they are on Ecto 1.

@Mrjaco12
Copy link

When I tried it locally it didn't work by default with ecto2-rc but maybe the version checker ignores rc/beta versions?

@danielberkompas
Copy link
Owner

Yeah, possibly. I think it will work once rc is out of the version name. In the meantime, you can use the override option in your deps.

{:ecto, "~> 2.0.0-rc3", override: true}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants