Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User not alterted when connection uses self-signed certs #782

Closed
kfp opened this issue Jan 23, 2017 · 1 comment
Closed

User not alterted when connection uses self-signed certs #782

kfp opened this issue Jan 23, 2017 · 1 comment

Comments

@kfp
Copy link

kfp commented Jan 23, 2017

DSub allows connection to subsonic backends over SSL with self-signed certs (rightly) but doesn't prompt the user which cert is used. This effectively eliminates the protection of SSL since in a MITM scenario DSub would happily accept the new cert without alerting the user.

A rudimentary form of certificate pinning could solve this without much inconvenience.

  1. On first connection to a server with a self-signed cert, present a dialog to the user to accept or deny.
  2. Store the cert fingerprint keyed to the domain
  3. On subsequent connections:
    3.a if the cert presented matches the fingerprint, don't alert the user
    3.b if the cert presented doesn't match, alert the user to accept or deny. On accept, replace stored fingerprint with the new one.

This won't protect people who simply click through warnings, but is similar to the pattern browsers follow with self-signed certs.

@daneren2005
Copy link
Owner

While this is definitely an issue, I already have an issue open for this at #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants