Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[question] why do you need an internet connection to permanent cache tracks? #922

Open
sentriz opened this issue Dec 6, 2018 · 2 comments · May be fixed by #1159
Open

[question] why do you need an internet connection to permanent cache tracks? #922

sentriz opened this issue Dec 6, 2018 · 2 comments · May be fixed by #1159

Comments

@sentriz
Copy link

sentriz commented Dec 6, 2018

steps to repro:

  • be online
  • play an album
  • let a few tracks cache on their own
  • turn off mobile data / wifi (without going to offline mode)
  • try permanently cache the album
  • notice the markers wont turn green

thank you (i love your app)
@djm2k
Copy link

djm2k commented Mar 19, 2019

Caching a song involves downloading it from your server which isn't possible when you're not connected to it.

@sentriz
Copy link
Author

sentriz commented Mar 19, 2019

@dddddd-mmmmmm I'm talking about the situation where the track is already cached (with a blue pin) but you want to permanently cache it with a green pin

flyingOwl added a commit to flyingOwl/Subsonic that referenced this issue Jan 27, 2024
@flyingOwl
Skip connection check during download if files are already local
80ae5ab 
This applies to "downloads" that actually just toggle the caching status
from "permanently cached" to just "cached" (and back). In these cases
the connection check is skipped which would prevent the tasks from being
run and trigger a warning.

Fixes daneren2005#922
@flyingOwl flyingOwl linked a pull request Jan 27, 2024 that will close this issue
Open
flyingOwl added a commit to flyingOwl/Subsonic that referenced this issue Jan 27, 2024
@flyingOwl
Skip connection check during download if files are already local
611c61e 
This applies to "downloads" that actually just toggle the caching status
from "permanently cached" to just "cached" (and back). In these cases
the connection check is skipped which would prevent the tasks from being
run and trigger a warning.

Fixes daneren2005#922
paroj pushed a commit to paroj/DSub2000 that referenced this issue Apr 1, 2024
@flyingOwl @paroj
Skip connection check during download if files are already local
9e6f04d 
This applies to "downloads" that actually just toggle the caching status
from "permanently cached" to just "cached" (and back). In these cases
the connection check is skipped which would prevent the tasks from being
run and trigger a warning.

Fixes daneren2005#922
paroj pushed a commit to paroj/DSub2000 that referenced this issue Apr 5, 2024
@flyingOwl @paroj
Skip connection check during download if files are already local
a31829f 
This applies to "downloads" that actually just toggle the caching status
from "permanently cached" to just "cached" (and back). In these cases
the connection check is skipped which would prevent the tasks from being
run and trigger a warning.

Fixes daneren2005#922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip connection check during download if files are already local flyingOwl/Subsonic
2 participants
@sentriz @djm2k