Skip to content

Commit

Permalink
Remove @ validation from network settings
Browse files Browse the repository at this point in the history
Was a PR to completely remove space and @ validation (#985), but I can see people easily pressing space without meaning to and not being able to see what is wrong.  If someone makes a good reason for it to be needed I will remove it, but for now just removing @ so people can do basic auth.
  • Loading branch information
daneren2005 committed Sep 22, 2020
1 parent 6bb8745 commit 7aff3fa
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,7 @@ public boolean onPreferenceChange(Preference preference, Object value) {
try {
String url = (String) value;
new URL(url);
if (url.contains(" ") || url.contains("@")) {
if (url.contains(" ")) {
throw new Exception();
}
} catch (Exception x) {
Expand All @@ -824,7 +824,7 @@ public boolean onPreferenceChange(Preference preference, Object value) {
}

new URL(url);
if (url.contains(" ") || url.contains("@")) {
if (url.contains(" ")) {
throw new Exception();
}
} catch (Exception x) {
Expand Down

0 comments on commit 7aff3fa

Please sign in to comment.