upload of coverage for windows started to fail?

[yarikoptic]

seems around 5 days ago but unclear yet if anything of our fault (unlikely)

Run codecov/codecov-action@v5
Run CC_ACTION_VERSION=$(cat ${GITHUB_ACTION_PATH}/src/version | grep 'CODECOV_ACTION_VERSION=' | cut -d\" -f2)
==> Running Action version 5.0.5
Run git config --global --add safe.directory D:\a\dandi-schema\dandi-schema
Run if [ "false" == 'true' ];
D:\a\_temp\0b469db9-ba0e-4772-9975-1dcc[29](https://github.com/dandi/dandi-schema/actions/runs/11939755686/job/33280949832?pr=261#step:6:30)98638b.sh: line 13: syntax error near unexpected token `|'
Error: Process completed with exit code 2.

and if expanding

      CC_TOKEN=$(echo ***
  
   | tr -d '\n')

so smells like may be someone pasted token with a new line at the end?

[yarikoptic]

even if so -- we did long ago

Ah -- we upgraded in

• [gh-actions](deps): Bump codecov/codecov-action from 4 to 5 #267
  to a new version. That explains the change in behavior...

but oddly it did fine in that PR

• https://github.com/dandi/dandi-schema/actions/runs/11887150936/job/33119435595

which was submitted by dependabot from our repo directly so token should have been the same... odd

[yarikoptic]

Submitted:

• Fail_ci_if_error not actually passing when false codecov/codecov-action#1703

[yarikoptic]

upon instructions from @jwodder I have re-set CODECOV_TOKEN organization wide while ensuring there is no trailing newlines/spaces. It seems to work out ok now! this was the test run I reran: https://github.com/dandi/dandi-schema/actions/runs/12290846730/job/34341055295