Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling when DOI creation fails #1710

Open
mvandenburgh opened this issue Oct 16, 2023 · 1 comment
Open

Improve error handling when DOI creation fails #1710

mvandenburgh opened this issue Oct 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working DOI

Comments

@mvandenburgh
Copy link
Member

Currently, DOI creation happens after the published dandiset is created on our side and committed to the database (see https://github.com/dandi/dandi-archive/blob/master/dandiapi/api/services/publish/__init__.py#L184). This means that if the call to the datacite API to create a new DOI fails, the dandiset will remain published but without a DOI. The publish workflow should be updated to instead fail gracefully and roll back the publish if the call to the datacite API fails.

@mvandenburgh mvandenburgh self-assigned this Oct 16, 2023
@waxlamp
Copy link
Member

waxlamp commented Feb 2, 2024

Even better would be to first create a draft DOI, and only continue on to perform the publish if that succeeds, and then finally promote the draft DOI to a prod DOI (which is an operation that can be retried until it succeeds).

(This is based on my tentative understanding of how Datacite works after hearing @danlamanna talk about this once.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DOI
Projects
None yet
Development

No branches or pull requests

2 participants