Skip to content

Commit ad6aa4b

Browse files
googlebergDan Dees
authored and
Dan Dees
committed
Mark nested builder as clean after clear is called
Omitting this step was leading to stale cached versions of nested messages. See protocolbuffers#10624
1 parent b0f7bff commit ad6aa4b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

java/core/src/main/java/com/google/protobuf/SingleFieldBuilderV3.java

+3
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,9 @@ public SingleFieldBuilderV3<MType, BType, IType> clear() {
199199
builder = null;
200200
}
201201
onChanged();
202+
// After clearing, parent is dirty, but this field builder is now clean and any changes should
203+
// trickle up.
204+
isClean = true;
202205
return this;
203206
}
204207

0 commit comments

Comments
 (0)