From a01a6f8d440b74f95196789b0f715379f35f0830 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 16 Jan 2019 12:28:48 +0100 Subject: [PATCH] test: change ciphers from 'RC4' to 'missing' This commit updates option ciphers from 'RC4' to 'missing' in test/parallel/test-tls-handshake-error.js. The motivation for this change is that this test is verifying that a 'no ciphers match' error be thrown, but 'RC4' might be among the ciphers supported by the OpenSSL version when dynamically linking. I ran into this specific issue when dynamically linking against OpenSSL 1.1.1 on RHEL8 using https://github.com/nodejs/node/pull/25381. --- test/parallel/test-tls-handshake-error.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-tls-handshake-error.js b/test/parallel/test-tls-handshake-error.js index 2aef1adcc38c1f..bbc2e3e0bf79be 100644 --- a/test/parallel/test-tls-handshake-error.js +++ b/test/parallel/test-tls-handshake-error.js @@ -19,7 +19,7 @@ const server = tls.createServer({ assert.throws(() => { tls.connect({ port: this.address().port, - ciphers: 'RC4' + ciphers: 'missing' }, common.mustNotCall()); }, /no cipher match/i);