-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable auth #92
Comments
Heya @Cheezzhead, that's no problem at all. I'm glad you like the app/UI! I'll open a quick pull request to add an "enabled" property to |
I think a separate PR too would be to add some env to DEFAULT_SERVER_URL=<blah>
FORCE_SERVER_URL=false/true
DEFAULT_AUTH=user:pass
FORCE_AUTH=false/true so for no auth: FORCE_SERVER_URL=true
FORCE_AUTH=true |
Looks awesome! How would the Edit: Tested it out with |
Heya @Cheezzhead the extra envs would be for the UI, so that if you have a disabled auth, you wouldn't need to see the login page |
I think this would be fantastic! I love the idea of being able to set an env variable to disable auth on the UI, as well as set an env variable for the default server as well. I'm just using Autopulse locally with no traffic going outside of my LAN so not too worried about auth. Plus will only be using one server instance of Autopulse so being able to set a default server for the UI makes a lot of sense. Thank you for all the work on this @dan-online 😊 |
All done @vember31 / @Cheezzhead. Let me know if you have any issues :) |
Thanks @dan-online ! I didn't get a chance to try it until just a moment ago (when it was merged into the main branch) but I might be doing it wrong? the UI kept giving me errors that it didn't seem to like the URL I provided & wouldn't start. Is this the proper way to get it setup?
Is that what you'd expect for a no-auth setup? I've since gone back to using auth & it works fine but I can reproduce the issue again if needed to help with any debugging :) |
Works for me!
I first set the variables on the backend container instead of the ui because I hadn't had my coffee yet, just mentioning it in case anybody else makes the same mistake haha |
Thank you both! With these two env vars set + doing config with auth.enabled: false FORCE_AUTH=true I was able to get it working as expected :) |
Description
First of all, thanks for this great app! I was initially planning on staying with Autoscan (at least until it wouldn't work anymore), but after testing out this project, it's the elegant UI that instantly convinced me to stay with this.
The only question I have is whether it's possible to disable authentication, for these reasons:
compose.yml
file, or as an option in theconfig.yaml
file) is generally considered unsafe. As this app doesn't currently have any built-in way to securely store and retrieve variables, one should consider any password set for this app to be insecure; meaning that another authorization service would have to be put in front of the web UI anyway. So practically speaking the ui needs 2 password to access in order for it to be secure.I'm willing to help out if necessary, just let me know!
Additional Information
No response
The text was updated successfully, but these errors were encountered: