ui: render profile pics in column headers #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb55
force-pushed
the
profile-header
branch
2 times, most recently
from
c1f2547 to
2ae023b
Compare
jb55
changed the title
|
The hardcoded positioning in the header is making it hard to change, was there a reason you did that @kernelkind ? |
jb55
force-pushed
the
profile-header
branch
2 times, most recently
from
9bd13c9 to
3909fb8
Compare
This is a much cleaner animation Signed-off-by: William Casarin <[email protected]>
Updated navigation to use a custom title renderer for more flexible rendering of navigation titles. This change decouples the rendering logic from predefined formats, enabling dynamic title compositions based on application context and data. This includes: - Refactoring `NavResponse` to introduce `NotedeckNavResponse` for handling unified navigation response data. - Adding `NavTitle` in `ui/column/header.rs` to handle rendering of navigation titles and profile images dynamically. - Updating route and timeline logic to support new rendering pipeline. - Replacing hardcoded title rendering with data-driven approaches. Benefits: - Simplifies navigation handling by consolidating title and action management. - Improves scalability for new navigation features without modifying core logic. - Enhances visual customization capabilities. Signed-off-by: William Casarin <[email protected]>
This uses less allocations, and once we switch to profile pictures in the header the old way won't be needed Signed-off-by: William Casarin <[email protected]>
even though we will replace this soon, it is still technically more correct than Timeline(1), etc
We also switch away from manual layout to centered cross-alignment. Changelog-Changed: Show profile pictures in column headers Fixes: #12 Signed-off-by: William Casarin <[email protected]>
Show back label, switch back to chevron design Signed-off-by: William Casarin <[email protected]>
This is pretty confusing otherwise Changelog-Changed: Only show column delete button when not navigating Fixes: #548 Signed-off-by: William Casarin <[email protected]>
Also right align profile pics when navigating Signed-off-by: William Casarin <[email protected]>
switched everything over to using centered CrossAlignment egui layout instead of fixed positioning. Everything in the title should be center aligned by default now using a child ui you can see this here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render profile pics in column headers!
better-nav.mp4