ed25519: vendor merlin dependency
#774
Conversation
`merlin` is currently a blocker for upgrading to `rand_core` v0.9 by way of the `transcript.build_rng().finalize()` function (which we only pass `ZeroRng` to). There is an open PR to update `rand_core` in `merlin` and I have pinged the relevant people to take a look, hopefully: zkcrypto/merlin#11 However, in the event we can't get `merlin` updated, this at least unblocks the `rand_core` upgrade, and is being opened as a contingency plan for that case. The PR has been implemented in a way that it should be easy to switch back to upstream `merlin` in the event they upgrade `rand_core`.
tarcieri
force-pushed
the
ed25519/vendor-merlin
branch
from
3c8578a to
63d10da
Compare
rozbb
left a comment
rozbb
left a comment
There was a problem hiding this comment.
Nice! I also don’t love it but I agree it’s the best way forward. Thanks for making this
|
Around transcripts, Arkworks' ark_serialize uses rust's std::io interface adapted to be no-std, but not no-alloc, although rust should provide a no-alloc io interface someday. All this they inherited from zcash. Arkworks itself mostly focuses upon field element based transcript schemes for recursion, but if you want a top level transcript that likes this std::io interface then for domain seperation you want the lengths to be hashed postfix after the data, becaue you've no idea how io::Write nests its calls. I wrote ark_transcript for this. All this is mostly useless to you guys, but if you ever get sick of merlin and do your own general thing then postfix lengths fit rust somewhat better. I doubt a general transcript thing is required here of course. |
merlinis currently a blocker for upgrading torand_corev0.9 by way of thetranscript.build_rng().finalize()function (which we only passZeroRngto).There is an open PR to update
rand_coreinmerlinand I have pinged the relevant people to take a look, hopefully: zkcrypto/merlin#11However, in the event we can't get
merlinupdated, this at least unblocks therand_coreupgrade, and is being opened as a contingency plan for that case.The PR has been implemented in a way that it should be easy to switch back to upstream
merlinin the event they upgraderand_core.