Skip to content

Commit 9ff7aeb

Browse files
committed
Remove static string printfs in utilities (-Wformat)
1 parent 266e05a commit 9ff7aeb

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

utils/check_query.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ static int error_count = 0;
124124

125125
static int verbose = 0;
126126

127-
static const char *title_format_string = "Rasqal RDF query test utility %s\n";
127+
static const char *title_string = "Rasqal RDF query test utility";
128128

129129

130130

@@ -361,7 +361,7 @@ main(int argc, char *argv[])
361361

362362
if(usage) {
363363
if(usage > 1) {
364-
fprintf(stderr, title_format_string, rasqal_version_string);
364+
fputs(title_string, stderr); fputs(rasqal_version_string, stderr); putc('\n', stderr);
365365
fputs("Rasqal home page: ", stderr);
366366
fputs(rasqal_home_url_string, stderr);
367367
fputc('\n', stderr);
@@ -380,7 +380,7 @@ main(int argc, char *argv[])
380380
if(help) {
381381
int i;
382382

383-
printf(title_format_string, rasqal_version_string);
383+
puts(title_string); puts(rasqal_version_string); putchar('\n');
384384
puts("Run an RDF query and check it against a known result.");
385385
printf("Usage: %s [OPTIONS] -g DATA -q QUERY-FILE -r RESULT-FILE\n\n", program);
386386

utils/roqet.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ static int warning_count = 0;
134134
static int warning_level = -1;
135135
static int ignore_errors = 0;
136136

137-
static const char *title_format_string = "Rasqal RDF query utility %s\n";
137+
static const char *title_string = "Rasqal RDF query utility ";
138138

139139
#define MAX_QUERY_ERROR_REPORT_LEN 512
140140

@@ -740,7 +740,7 @@ print_help(rasqal_world* world, raptor_world* raptor_world_ptr)
740740
{
741741
unsigned int i;
742742

743-
printf(title_format_string, rasqal_version_string);
743+
puts(title_string); puts(rasqal_version_string); putchar('\n');
744744
puts("Run an RDF query against data into formatted results.");
745745
printf("Usage: %s [OPTIONS] <query URI> [base URI]\n", program);
746746
printf(" %s [OPTIONS] -e <query string> [base URI]\n", program);
@@ -1213,7 +1213,7 @@ main(int argc, char *argv[])
12131213

12141214
if(usage) {
12151215
if(usage > 1) {
1216-
fprintf(stderr, title_format_string, rasqal_version_string);
1216+
fputs(title_string, stderr); fputs(rasqal_version_string, stderr); putc('\n', stderr);
12171217
fputs("Rasqal home page: ", stderr);
12181218
fputs(rasqal_home_url_string, stderr);
12191219
fputc('\n', stderr);

utils/srxread.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
#endif
5454

5555

56-
static const char *title_format_string = "Rasqal RDF query results utility %s\n";
56+
static const char *title_string = "Rasqal RDF query results utility";
5757

5858
static char *program = NULL;
5959

@@ -95,7 +95,7 @@ main(int argc, char *argv[])
9595
if(argc < 2 || argc > 4) {
9696
int i;
9797

98-
printf(title_format_string, rasqal_version_string);
98+
puts(title_string); puts(rasqal_version_string); putchar('\n');
9999
puts("Read an RDF Query results file in one format and print in another\n");
100100
printf("Usage: %s <results filename> [read format [write format]]\n\n",
101101
program);

utils/testrunner.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ static struct option long_options[] =
103103
static int error_count = 0;
104104
static int warning_count = 0;
105105

106-
static const char *title_format_string = "Rasqal RDF test runner utility %s\n";
106+
static const char *title_string = "Rasqal RDF test runner utility";
107107

108108

109109
static void
@@ -146,7 +146,7 @@ testrunner_log_handler(void *data, raptor_log_message *message)
146146
static void
147147
print_help(rasqal_world* world, raptor_world* raptor_world_ptr)
148148
{
149-
printf(title_format_string, rasqal_version_string);
149+
puts(title_string); puts(rasqal_version_string); putchar('\n');
150150
puts("Run an RDF query test suite.");
151151
printf("Usage: %s [OPTIONS] <manifest URI> [base URI]\n", program);
152152

@@ -264,7 +264,7 @@ main(int argc, char *argv[])
264264

265265
if(usage) {
266266
if(usage > 1) {
267-
fprintf(stderr, title_format_string, rasqal_version_string);
267+
fputs(title_string, stderr); fputs(rasqal_version_string, stderr); putc('\n', stderr);
268268
fputs("Rasqal home page: ", stderr);
269269
fputs(rasqal_home_url_string, stderr);
270270
fputc('\n', stderr);

0 commit comments

Comments
 (0)