refactor: modify one-time fetch to be format-agnostic

return a string, not JSON

Author: marisademeglio

src/main/one-time-fetch.ts

@@ -8,12 +8,8 @@ async function oneTimeFetch(url) {
     if (url.length == 0) return false
 
     let res = await fetch(url)
-    if (res) {
-        return res.json()
-    }
-    else {
-        return null
-    }
+    let txt = await res.text()
+    return txt ?? null
 }
 
 function setupOneTimeFetchEvent() {

src/renderer/bridge/ipcs/oneTimeFetch.ts

@@ -1,12 +1,12 @@
 import { ipcRenderer } from 'electron'
 import * as events from 'shared/main-renderer-events'
 
-// get JSON data from an arbitrary endpoint
+// get data from an arbitrary endpoint using main process fetch
 export function oneTimeFetch(url) {
-    return new Promise<JSON>((resolve, reject) => {
-        ipcRenderer.send(events.IPC_EVENT_oneTimeFetch, url)
-        ipcRenderer.once(events.IPC_EVENT_oneTimeFetch, (event, res: JSON) => {
+    return new Promise<string>((resolve, reject) => {
+        ipcRenderer.once(events.IPC_EVENT_oneTimeFetch, (event, res) => {
             resolve(res)
         })
+        ipcRenderer.send(events.IPC_EVENT_oneTimeFetch, url)
     })
 }

src/renderer/utils/sponsorship.ts

@@ -12,10 +12,11 @@ let defaultSponsorshipMessage = {
 async function updateSponsorshipMessage() {
     // fetch the latest sponsorship message
     try {
-        let sponsorshipData = await App.oneTimeFetch(
+        let data = await App.oneTimeFetch(
             'https://dl.daisy.org/tools/sponsorship.json'
         )
-        if (sponsorshipData) {
+        if (data) {
+            let sponsorshipData = JSON.parse(data)
             return sponsorshipData['PipelineApp']['en']
         } else {
             return defaultSponsorshipMessage