Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping self.α_μ and self.α_Σ in continuous action space #12

Open
albertbou92 opened this issue Aug 12, 2021 · 1 comment
Open

Comments

@albertbou92
Copy link

Hello Dai,

On lines 365 and 366 of file mpo.py the code is the following:

      self.α_μ = np.clip(0.0, self.α_μ, self.α_μ_max)
      self.α_Σ = np.clip(0.0, self.α_Σ, self.α_Σ_max)

shouldn't it be like that?

      self.α_μ = np.clip(self.α_μ, 0.0, self.α_μ_max)
      self.α_Σ = np.clip(self.α_Σ, 0.0,  self.α_Σ_max)

Regards!

@daisatojp
Copy link
Owner

Hi @albertbou92

Thank you. I didn't notice the mistake. Fortunately, (but it is the reason I didn't notice), np.clip(0.0, self.α_μ, self.α_μ_max) behaves exactly the same way as np.clip(self.α_μ, 0.0, self.α_μ_max). Anyway I will fix it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants