Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer possible to get ID of failed node #90

Open
kyrias opened this issue Jan 29, 2025 · 0 comments
Open

No longer possible to get ID of failed node #90

kyrias opened this issue Jan 29, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@kyrias
Copy link
Collaborator

kyrias commented Jan 29, 2025

Previously the DagError::TaskError type contained the task name, task ID, and the node-provided error string. The new equivalent of this error type appears to be GraphError::ExecutionFailed but it only contains a formatted string.

It would be more user friendly if it still contained node_name, node_id, and error as struct members and then have the Display implementation build the string instead so that our error handling can reliably get the actual node ID that failed.

@genedna genedna added the enhancement New feature or request label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants