Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced to use exit error codes for normal tasks #54

Closed
aminya opened this issue Dec 17, 2023 · 0 comments · Fixed by #55
Closed

Forced to use exit error codes for normal tasks #54

aminya opened this issue Dec 17, 2023 · 0 comments · Fixed by #55

Comments

@aminya
Copy link
Collaborator

aminya commented Dec 17, 2023

#50 added a new change that does not make sense for normal outputs when someone is not running Shell commands. Rust has rich error-handling features, which are much better than exit codes.

Also, Output::error method is changed, which is a breaking change for all the users of Dagrs. We have to revert this change by adding a new status field like ErrWithExitCode

Originally posted by @aminya in #50 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant